GitHub Issue 903: Remove Cross-Container Sample and Data Class Import Feature#7698
Merged
Conversation
|
|
||
| if (dataRow == null && allowCrossContainer) | ||
| { | ||
| // data not found from queryTable but exist in exp.data, which happens when users lack of permission to data's container |
Contributor
There was a problem hiding this comment.
I don't quite follow. Shouldn't the row in the queryTable's container always align with the container of the exp.data? Isn't it the same thing, hence why we don't have a container column on the provisioned table?
Contributor
Author
There was a problem hiding this comment.
queryTable is a filtered ContainerFilterable table with container filter for the DataClassData table, that checks for user's permission. ExperimentService.get().getTinfoData()returns a SchemaTableInfo, that doesn't care about user, nor container.
labkey-danield
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR removes the support for cross-container sample and data class import feature. The feature allowed import of samples and data class rows belonging to other folders in a single file, which was implemented via temp partitioned files, which is error-prone. Attempts to update/merge rows that does not exist in the current container now generate a generic error message ("Sample/Data does not exist in : "), without revealing its existence in other folders.
Related Pull Requests
Changes